Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint error #347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

shuuji3
Copy link

@shuuji3 shuuji3 commented Dec 28, 2024

πŸ”— Linked issue

N/A (see #345)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • πŸ“° Content (a new article or a change in the content folder)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR fixes the lint error on the main branch. The previous GitHub Actions log was removed now, but it I found out there were only two simple lint errors.

The error of pnpm run lint fixed:

$ pnpm run lint

> website@ lint /home/shuuji3/dev/unjs-website
> eslint .

(node:1034756) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)

/home/shuuji3/dev/unjs-website/components/app/AppAlert.vue
  10:23  error  Expected to return a value in computed function  vue/return-in-computed-property

/home/shuuji3/dev/unjs-website/components/learn/LearnCard.vue
  13:31  error  Expected to return a value in computed function  vue/return-in-computed-property

βœ– 2 problems (2 errors, 0 warnings)

 ELIFECYCLE  Command failed with exit code 1.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
    • N/A - no need to modify documentation for this lint fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant