fix: flyout textBlock wrapping with long text #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Aug 30, 2023
| @@ -245,6 +245,7 @@ | |||
| <TextBlock x:Name="TextBlock" | |||
| Grid.Column="1" | |||
| Margin="12,0,0,0" | |||
| TextWrapping="NoWrap" | |||
There was a problem hiding this comment.
If everything works on Windows without this change, then this change masks an Uno bug and is only a workaround not a fix for the underlying issue.
There was a problem hiding this comment.
well, it actually doesn't work on GTK, all the platforms works without this change :/
There was a problem hiding this comment.
Then this is only a workaround. In case we went we such a workaround, make sure to have an issue open in unoplatform/uno repo and link the issue in a comment here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: [Gallery][Skia.GTK] 'Help'
Flyout'Send Feedback' text is not displaying correctly, and the word 'Colors' is missingPR Type
What kind of change does this PR introduce?
Description
flyout textBlock wrapping with long text
PR Checklist
Please check if your PR fulfills the following requirements:
Other information