Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update pull_request_template.md to add more docs in PR Checklist #1255

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agneszitte
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Other: PR Template update

Description

chore: Update pull_request_template.md to add docs in PR Checklist

@Xiaoy312
Copy link
Contributor

im getting mixed feelings for all these checks... the sheer numbe is getting a bit out of hand...
also you seem to forgot to mention Uno.Themes/doc/styles/ which we need to update on control style updates

@agneszitte
Copy link
Contributor Author

agneszitte commented Oct 24, 2023

im getting mixed feelings for all these checks... the sheer numbe is getting a bit out of hand... also you seem to forgot to mention Uno.Themes/doc/styles/ which we need to update on control style updates

Hum you are not wrong, that is starting to be a lot, but also it is very easy to forget some docs. Hum let me rethink that

@agneszitte agneszitte marked this pull request as draft October 24, 2023 20:10
@Xiaoy312
Copy link
Contributor

Xiaoy312 commented Oct 24, 2023

maybe just a single bullet point to remind them to update the relevant docs, and links the major folders (/doc, /doc/styles/)
less is more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants