Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Commit

Permalink
add the sort ability to assign placings to events. also specs and oth…
Browse files Browse the repository at this point in the history
…er goodies
  • Loading branch information
[email protected] committed May 9, 2019
1 parent 11beaf5 commit 4683bef
Show file tree
Hide file tree
Showing 16 changed files with 358 additions and 7 deletions.
1 change: 1 addition & 0 deletions .rspec
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
--require spec_helper
49 changes: 49 additions & 0 deletions app/models/event.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,53 @@ class Event < ApplicationRecord

has_many :scores
belongs_to :tournament

def standings
groups = []
ungrouped_scores = scores

groups[6], ungrouped_scores = ungrouped_scores.partition{ |score| score.disqualified }
groups[5], ungrouped_scores = ungrouped_scores.partition{ |score| !score.participated }
groups[4], ungrouped_scores = ungrouped_scores.partition{ |score| score.score.nil? }

groups[3], ungrouped_scores = ungrouped_scores.partition{ |score| score.tier == 4 }
groups[2], ungrouped_scores = ungrouped_scores.partition{ |score| score.tier == 3 }
groups[1], ungrouped_scores = ungrouped_scores.partition{ |score| score.tier == 2 }
groups[0] = ungrouped_scores

# Holds arrays of [placing, score]
standings = []
placing = 1
for tier in 0..3
groups[tier].sort_by!{ |score| score.score }
groups[tier].reverse! if(scoring == :high)

groups[tier].each do |score|

standings << [placing, score]
placing = placing + 1
end
end

groups[4].each do |score|
standings << [tournament.number_of_teams, score]
end

groups[5].each do |score|
standings << [1 + tournament.number_of_teams, score]
end

groups[6].each do |score|
standings << [2 + tournament.number_of_teams, score]
end

standings
end

def placing(team_number)
team_standing = standings.select{ |standing| standing[1].team.number == team_number }
# Error is team not found, uncaught
team_standing[0][0]
end

end
2 changes: 2 additions & 0 deletions app/models/score.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
class Score < ApplicationRecord
belongs_to :event
belongs_to :team

# tier: The tier of the team. Integer > 0
end
4 changes: 4 additions & 0 deletions app/models/tournament.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,8 @@ class Tournament < ApplicationRecord

validates :level, presence: true
validates :division, presence: true

def number_of_teams
teams.length
end
end
3 changes: 2 additions & 1 deletion db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 2019_05_08_234646) do
ActiveRecord::Schema.define(version: 2019_05_09_005622) do

# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
Expand Down Expand Up @@ -44,6 +44,7 @@
t.integer "tiebreaker_place"
t.datetime "created_at", precision: 6, null: false
t.datetime "updated_at", precision: 6, null: false
t.integer "tier"
t.index ["event_id"], name: "index_scores_on_event_id"
t.index ["team_id"], name: "index_scores_on_team_id"
end
Expand Down
8 changes: 8 additions & 0 deletions spec/factories/events.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
FactoryBot.define do
factory :event do
name { "Test Event" }
trial { false }
trialed { false }
scoring { 0 }
end
end
21 changes: 21 additions & 0 deletions spec/factories/scores.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
FactoryBot.define do
factory :score do
participated { true }
disqualified { false }
score { 100*rand() }
tiebreaker_place { 1 }
tier { 1 }

factory :disqualfied_score do
disqualified { true }
end

factory :no_show_score do
participated { false }
end

factory :no_points_score do
score { nil }
end
end
end
10 changes: 10 additions & 0 deletions spec/factories/teams.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
FactoryBot.define do
factory :team do
school { "Example School" }
suffix { "Jr. "}
subdivision { 0 }
number { 1 }
city { "Townsburg" }
state { 19 }
end
end
29 changes: 29 additions & 0 deletions spec/factories/tournaments.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
FactoryBot.define do
factory :tournament do
name { "Test Tournament" }
level { 0 }
division { 1 }
year { 2019 }
date { Date.today }

factory :filled_tournament do
after(:create) do |t|
for ind in 1..10 do
create(:event, name: "Event #{ind}",tournament: t)
create(:team, school: "School #{ind}", number: ind, tournament: t)
end
end

factory :completed_tournament do
after(:create) do |t|
t.teams.each do |team|
t.events.each do |event|
create(:score, team: team, event: event)
end
end
end

end
end
end
end
46 changes: 46 additions & 0 deletions spec/models/event_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
require 'rails_helper'

RSpec.describe Event, type: :model do
describe 'event#standings' do
let(:t) { create(:completed_tournament) }
it 'has standings in ascending order' do
event = t.events[0]
expect(event.standings.map{ |standing| standing[0]}).to eq((1..10).to_a)
end

it 'has standings sort scores' do
event = t.events[0]
sorted_scores = event.scores.sort_by{ |score| score.score}
expect(event.standings.map{ |standing| standing[1]}).to eq(sorted_scores)
end

it 'has DQs as tournament_size + 2' do
event = t.events[0]
allow(event.scores[5]).to receive(:disqualified).and_return(true)
expect(event.standings.map{ |standing| standing[0]}[9]).to eq(t.number_of_teams + 2)
end

it 'has no shows as tournament_size + 1' do
event = t.events[0]
allow(event.scores[5]).to receive(:participated).and_return(false)
expect(event.standings.map{ |standing| standing[0]}[9]).to eq(t.number_of_teams + 1)
end

it 'has participation without points as tournament_size' do
event = t.events[0]
allow(event.scores[5]).to receive(:participated).and_return(true)
allow(event.scores[5]).to receive(:score).and_return(nil)
expect(event.standings.map{ |standing| standing[0]}[9]).to eq(t.number_of_teams)
end
end

describe 'event#placing' do
let(:t) { create(:completed_tournament) }
it 'returns the correct placing' do
event = t.events[0]
sorted_scores = event.scores.sort_by{ |score| score.score}
team = sorted_scores[5].team.number
expect(event.placing(team)).to eq(5+1)
end
end
end
9 changes: 9 additions & 0 deletions spec/models/tournament_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
require 'rails_helper'

RSpec.describe Tournament, type: :model do
it 'return tournament size' do
t = create(:filled_tournament)
expect(t.number_of_teams).to eq(10)
end

end
61 changes: 61 additions & 0 deletions spec/rails_helper.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
# This file is copied to spec/ when you run 'rails generate rspec:install'
require 'spec_helper'
ENV['RAILS_ENV'] ||= 'test'
require File.expand_path('../../config/environment', __FILE__)
# Prevent database truncation if the environment is production
abort("The Rails environment is running in production mode!") if Rails.env.production?
require 'rspec/rails'
# Add additional requires below this line. Rails is not loaded until this point!

# Requires supporting ruby files with custom matchers and macros, etc, in
# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
# run as spec files by default. This means that files in spec/support that end
# in _spec.rb will both be required and run as specs, causing the specs to be
# run twice. It is recommended that you do not name files matching this glob to
# end with _spec.rb. You can configure this pattern with the --pattern
# option on the command line or in ~/.rspec, .rspec or `.rspec-local`.
#
# The following line is provided for convenience purposes. It has the downside
# of increasing the boot-up time by auto-requiring all files in the support
# directory. Alternatively, in the individual `*_spec.rb` files, manually
# require only the support files necessary.
#
# Dir[Rails.root.join('spec', 'support', '**', '*.rb')].each { |f| require f }

# Checks for pending migrations and applies them before tests are run.
# If you are not using ActiveRecord, you can remove these lines.
begin
ActiveRecord::Migration.maintain_test_schema!
rescue ActiveRecord::PendingMigrationError => e
puts e.to_s.strip
exit 1
end
RSpec.configure do |config|
# Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
config.fixture_path = "#{::Rails.root}/spec/fixtures"

# If you're not using ActiveRecord, or you'd prefer not to run each of your
# examples within a transaction, remove the following line or assign false
# instead of true.
config.use_transactional_fixtures = true

# RSpec Rails can automatically mix in different behaviours to your tests
# based on their file location, for example enabling you to call `get` and
# `post` in specs under `spec/controllers`.
#
# You can disable this behaviour by removing the line below, and instead
# explicitly tag your specs with their type, e.g.:
#
# RSpec.describe UsersController, :type => :controller do
# # ...
# end
#
# The different available types are documented in the features, such as in
# https://relishapp.com/rspec/rspec-rails/docs
config.infer_spec_type_from_file_location!

# Filter lines from Rails gems in backtraces.
config.filter_rails_from_backtrace!
# arbitrary gems may also be filtered via:
# config.filter_gems_from_backtrace("gem name")
end
102 changes: 102 additions & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
# This file was generated by the `rspec --init` command. Conventionally, all
# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
# The generated `.rspec` file contains `--require spec_helper` which will cause
# this file to always be loaded, without a need to explicitly require it in any
# files.
#
# Given that it is always loaded, you are encouraged to keep this file as
# light-weight as possible. Requiring heavyweight dependencies from this file
# will add to the boot time of your test suite on EVERY test run, even for an
# individual file that may not need all of that loaded. Instead, consider making
# a separate helper file that requires the additional dependencies and performs
# the additional setup, and require it from the spec files that actually need
# it.
#
# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
require 'support/factory_bot'

RSpec.configure do |config|
# rspec-expectations config goes here. You can use an alternate
# assertion/expectation library such as wrong or the stdlib/minitest
# assertions if you prefer.
config.expect_with :rspec do |expectations|
# This option will default to `true` in RSpec 4. It makes the `description`
# and `failure_message` of custom matchers include text for helper methods
# defined using `chain`, e.g.:
# be_bigger_than(2).and_smaller_than(4).description
# # => "be bigger than 2 and smaller than 4"
# ...rather than:
# # => "be bigger than 2"
expectations.include_chain_clauses_in_custom_matcher_descriptions = true
end

# rspec-mocks config goes here. You can use an alternate test double
# library (such as bogus or mocha) by changing the `mock_with` option here.
config.mock_with :rspec do |mocks|
# Prevents you from mocking or stubbing a method that does not exist on
# a real object. This is generally recommended, and will default to
# `true` in RSpec 4.
mocks.verify_partial_doubles = true
end

# This option will default to `:apply_to_host_groups` in RSpec 4 (and will
# have no way to turn it off -- the option exists only for backwards
# compatibility in RSpec 3). It causes shared context metadata to be
# inherited by the metadata hash of host groups and examples, rather than
# triggering implicit auto-inclusion in groups with matching metadata.
config.shared_context_metadata_behavior = :apply_to_host_groups

# The settings below are suggested to provide a good initial experience
# with RSpec, but feel free to customize to your heart's content.
=begin
# This allows you to limit a spec run to individual examples or groups
# you care about by tagging them with `:focus` metadata. When nothing
# is tagged with `:focus`, all examples get run. RSpec also provides
# aliases for `it`, `describe`, and `context` that include `:focus`
# metadata: `fit`, `fdescribe` and `fcontext`, respectively.
config.filter_run_when_matching :focus
# Allows RSpec to persist some state between runs in order to support
# the `--only-failures` and `--next-failure` CLI options. We recommend
# you configure your source control system to ignore this file.
config.example_status_persistence_file_path = "spec/examples.txt"
# Limits the available syntax to the non-monkey patched syntax that is
# recommended. For more details, see:
# - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
# - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
# - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
config.disable_monkey_patching!
# This setting enables warnings. It's recommended, but in some cases may
# be too noisy due to issues in dependencies.
config.warnings = true
# Many RSpec users commonly either run the entire suite or an individual
# file, and it's useful to allow more verbose output when running an
# individual spec file.
if config.files_to_run.one?
# Use the documentation formatter for detailed output,
# unless a formatter has already been configured
# (e.g. via a command-line flag).
config.default_formatter = "doc"
end
# Print the 10 slowest examples and example groups at the
# end of the spec run, to help surface which specs are running
# particularly slow.
config.profile_examples = 10
# Run specs in random order to surface order dependencies. If you find an
# order dependency and want to debug it, you can fix the order by providing
# the seed, which is printed after each run.
# --seed 1234
config.order = :random
# Seed global randomization in this process using the `--seed` CLI option.
# Setting this allows you to use `--seed` to deterministically reproduce
# test failures related to randomization by passing the same `--seed` value
# as the one that triggered the failure.
Kernel.srand config.seed
=end
end
5 changes: 5 additions & 0 deletions spec/support/factory_bot.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
require 'factory_bot'

RSpec.configure do |config|
config.include FactoryBot::Syntax::Methods
end
Loading

0 comments on commit 4683bef

Please sign in to comment.