Skip to content

Commit

Permalink
fix(NumberField): missing data-disabled (#1212)
Browse files Browse the repository at this point in the history
* fix(NumberField): missing data-disabled

* test: add checker for root
  • Loading branch information
zernonia authored Aug 11, 2024
1 parent 1fea8fa commit 7354f25
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/radix-vue/src/NumberField/NumberField.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,10 @@ describe('numberField', () => {
})

it('should not be changed when disabled', async () => {
const { input, increment, decrement } = setup({ defaultValue: 0, disabled: true })
const { root, input, increment, decrement } = setup({ defaultValue: 0, disabled: true })

expect(root.getAttribute('data-disabled')).toBe('')
expect(input.getAttribute('data-disabled')).toBe('')
await fireEvent.keyDown(input, { key: kbd.ARROW_UP })
expect(input.value).toBe('0')
await fireEvent.keyDown(input, { key: kbd.ARROW_DOWN })
Expand Down
1 change: 1 addition & 0 deletions packages/radix-vue/src/NumberField/NumberFieldRoot.vue
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ provideNumberFieldRootContext({
role="group"
:as="as"
:as-child="asChild"
:data-disabled="disabled ? '' : undefined"
>
<slot
:model-value="modelValue"
Expand Down

0 comments on commit 7354f25

Please sign in to comment.