Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Pagination): add conditions for 2 siblings edge case #1024

Merged
merged 2 commits into from
Jun 23, 2024
Merged

fix(Pagination): add conditions for 2 siblings edge case #1024

merged 2 commits into from
Jun 23, 2024

Conversation

epr3
Copy link
Collaborator

@epr3 epr3 commented Jun 22, 2024

Fixes #970.

zernonia
zernonia approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀

@zernonia zernonia merged commit de1340c into main Jun 23, 2024
5 checks passed
@epr3 epr3 deleted the 970-bugfix-pagination branch June 23, 2024 13:30
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 0da2fb7

radix-vue

npm i https://pkg.pr.new/radix-vue@1024

templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zernonia zernonia zernonia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Pagination hides a single page behind an ellipsis
2 participants
@epr3 @zernonia