Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Editable): do not submit if editable is not in edit mode #1038

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix(Editable): do not submit if editable is not in edit mode #1038

merged 1 commit into from
Jun 26, 2024

Conversation

epr3
Copy link
Collaborator

@epr3 epr3 commented Jun 25, 2024

Fixes #1036.

@zernonia zernonia merged commit acf2861 into main Jun 26, 2024
3 checks passed
@epr3 epr3 deleted the 1036-bugfix-editable branch June 26, 2024 06:22
@Tinoooo
Copy link

Tinoooo commented Jun 26, 2024

Is there a practical way to remove the whole event listener (when isEditing === true) instead of ignoring the event? This might be more performant.

@epr3
Copy link
Collaborator Author

epr3 commented Jun 26, 2024

@Tinoooo which event listener?

@Tinoooo
Copy link

Tinoooo commented Jun 26, 2024 •
edited
Loading

@epr3 The one in DismissableLayer.

Thank you for the fix btw 🙏.

@epr3
Copy link
Collaborator Author

epr3 commented Jun 26, 2024

Oh, got it. Will look into a solution 👍🏻

@epr3 epr3 mentioned this pull request Jun 26, 2024
Merged
@epr3 epr3 restored the 1036-bugfix-editable branch June 26, 2024 20:24
@epr3 epr3 deleted the 1036-bugfix-editable branch June 26, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Editable submits on every single click
3 participants
@epr3 @Tinoooo @zernonia