Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Editable): use Primitive for input to enable textarea usage #1045

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

epr3
Copy link
Collaborator

@epr3 epr3 commented Jun 26, 2024

Implements #1044.

Editable component input implementation aligned to NumberField input implementation.

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback. Else LGTM!

packages/radix-vue/src/Editable/EditableRoot.vue Outdated Show resolved Hide resolved
packages/radix-vue/src/Editable/EditableRoot.vue Outdated Show resolved Hide resolved
Copy link

pkg-pr-new bot commented Jun 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: d00e7ce

radix-vue

npm i https://pkg.pr.new/radix-vue@1045


templates

@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Jun 27, 2024

https://stackblitz.com/edit/tqkblp?file=src%2FApp.vue

New lines are not printout in EditablePreview component, maybe serialize or stringify or parse could help?

eg: Radix Vue' \\n QQWE\n\nNew Line\n\nNew Line

Black text is the log which removed in new commit

image

@epr3
Copy link
Collaborator Author

epr3 commented Jun 27, 2024

@sadeghbarati I think adding the whitespace-pre class to the EditablePreview component would render the new lines.

@sadeghbarati
Copy link
Collaborator

@epr3 Yes you right, that Black Text in above image was the redundant log value you removed in chore(Editable): remove log variable and redundant defaultValue

even without that class it is working 👍

@zernonia zernonia merged commit 6926f8b into main Jun 27, 2024
6 checks passed
@epr3 epr3 deleted the 1044-feature-editable branch June 27, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants