Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove calendar step prop #1101

Merged
merged 2 commits into from
Jul 7, 2024
Merged

refactor: remove calendar step prop #1101

merged 2 commits into from
Jul 7, 2024

Conversation

epr3
Copy link
Collaborator

@epr3 epr3 commented Jul 6, 2024

Hello,

This PR fully removes the step property from the CalendarNext/CalendarPrev components, plus adjusts the utility functions to take this change into account.

I've marked this PR with the v2 label to keep track of it.

@epr3 epr3 added the v2 label Jul 6, 2024
Copy link

Deploying radix-vue with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e45c7d
Status: ✅  Deploy successful!
Preview URL: https://c41c2fe4.radix-vue.pages.dev
Branch Preview URL: https://remove-calendar-step.radix-vue.pages.dev

View logs

@epr3 epr3 changed the title Refactor: remove calendar step prop refactor: remove calendar step prop Jul 6, 2024
@zernonia
Copy link
Member

zernonia commented Jul 6, 2024

@epr3 I've started a branch on v2. Let's change the merge target to that ya 😁

I wanna keep v2 changes clean from main as we might have some minor patches that need to go through

@epr3 epr3 changed the base branch from main to v2 July 6, 2024 21:09
@zernonia zernonia merged commit ec146dd into v2 Jul 7, 2024
6 checks passed
@sadeghbarati sadeghbarati deleted the remove-calendar-step branch July 23, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants