Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dates): disable state not affect tabindex and relevant button #1146

Conversation

zernonia
Copy link
Member

@zernonia zernonia commented Jul 19, 2024

  • remove tabindex when disabled
  • disable button when the root was disabled
  • prevent focusable on cell trigger when disabled

Copy link
Collaborator

@epr3 epr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

pkg-pr-new bot commented Jul 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 763ac91

radix-vue

npm i https://pkg.pr.new/radix-vue@1146


templates

@zernonia zernonia merged commit e3bc0cc into main Jul 19, 2024
5 checks passed
@sadeghbarati sadeghbarati deleted the 1129-bug-date-picker-and-possibly-all-related-components-are-not-handling-disabled branch July 23, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Date Picker (and possibly all related components) are not handling disabled
2 participants