Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Splitter): not updating SplitterResizeHandle cursor style properly when direction changes #1235

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix(Splitter): not updating SplitterResizeHandle cursor style properly when direction changes #1235

merged 1 commit into from
Aug 19, 2024

Conversation

Gertiozuni
Copy link
Contributor

Problem

When toggling direction on SplitterGroup

 <SplitterGroup :direction="direction">
 ...
 </SplitterGroup>

resize cursor styles stick to its initial values (https://stackblitz.com/edit/gdyqde?file=src%2FApp.vue)

image

Solution

Made SplitterGroup to provide a reactive direction

zernonia
zernonia approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Gertiozuni !! 🔥

@zernonia zernonia merged commit 74a750f into unovue:main Aug 19, 2024
4 checks passed
@Gertiozuni Gertiozuni deleted the fix/splitter-resize-handle-cursor branch August 19, 2024 14:43
@renovate renovate bot mentioned this pull request Sep 27, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zernonia zernonia zernonia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gertiozuni @zernonia