-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation on how to export model from Colab #1657
base: main
Are you sure you want to change the base?
Conversation
Related to unslothai#1615 Add documentation and function for exporting models from Colab to local machines. * **README.md**: Add a new section titled "Exporting Models from Colab to Local Machine" under "✨ Finetune for Free" with detailed steps for exporting models from Colab to local machines. * **CONTRIBUTING.md**: Add a note about the new documentation section for exporting models from Colab. * **unsloth/save.py**: Add a new function `export_model_to_local` to handle exporting models from Colab to local machines.
Thanks! I'll review this! Appreciate the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments - good work!
## Note | ||
We have added a new section in the `README.md` under "✨ Finetune for Free" titled "Exporting Models from Colab to Local Machine" with detailed steps. Please refer to it for guidance on exporting models from Colab to your local machine. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Note | |
We have added a new section in the `README.md` under "✨ Finetune for Free" titled "Exporting Models from Colab to Local Machine" with detailed steps. Please refer to it for guidance on exporting models from Colab to your local machine. |
This is probably not necessary!
@@ -39,6 +39,39 @@ All notebooks are **beginner friendly**! Add your dataset, click "Run All", and | |||
- This [continued pretraining notebook](https://colab.research.google.com/github/unslothai/notebooks/blob/main/nb/Mistral_v0.3_(7B)-CPT.ipynb) is for learning another language | |||
- Click [here](https://docs.unsloth.ai/) for detailed documentation for Unsloth. | |||
|
|||
## Exporting Models from Colab to Local Machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this maybe to the docs or wiki instead? :) @shimmyshimmer can help on that!
@@ -1025,69 +1026,6 @@ def save_to_gguf( | |||
) | |||
pass | |||
|
|||
# Determine whether the system already has llama.cpp installed and the scripts are executable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure why this is removed?
@@ -2347,3 +2287,27 @@ def patch_saving_functions(model, vision = False): | |||
pass | |||
return model | |||
pass | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this is a reasonable function - we can probably just include this if that works :)
Related to #1615
Add documentation and function for exporting models from Colab to local machines.
export_model_to_local
to handle exporting models from Colab to local machines.