-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #81 from upmaru/feature/handle-component-instance-…
…update Add ability to modify component instance
- Loading branch information
Showing
12 changed files
with
289 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| defmodule Uplink.Components.Instance.Modify do | ||
| use Oban.Worker, queue: :components, max_attempts: 1 | ||
|
|
||
| alias Uplink.Drivers | ||
| alias Uplink.Clients.Instellar | ||
|
|
||
| def perform(%Oban.Job{args: %{"component_id" => component_id} = job_params}) do | ||
| case Instellar.get_component(component_id) do | ||
| {:ok, component_params} -> | ||
| handle_perform(component_params, job_params) | ||
|
|
||
| {:error, error} -> | ||
| {:error, error} | ||
| end | ||
| end | ||
|
|
||
| defp handle_perform( | ||
| %{ | ||
| "generator" => %{"module" => module}, | ||
| "credential" => credential_params | ||
| }, | ||
| %{ | ||
| "component_id" => component_id, | ||
| "component_instance_id" => component_instance_id, | ||
| "variable_id" => variable_id | ||
| } = job_args | ||
| ) do | ||
| options = | ||
| job_args | ||
| |> Map.get("arguments", %{}) | ||
| |> Enum.map(fn {k, v} -> {String.to_atom(k), v} end) | ||
|
|
||
| with {:ok, component_instance_attributes} <- | ||
| Instellar.get_component_instance(component_id, component_instance_id), | ||
| {:ok, credential} <- | ||
| Drivers.perform( | ||
| :modify, | ||
| module, | ||
| %{ | ||
| "credential" => credential_params, | ||
| "component_instance" => component_instance_attributes | ||
| }, | ||
| options | ||
| ), | ||
| {:ok, component_instance_attributes} <- | ||
| Instellar.update_component_instance( | ||
| component_id, | ||
| component_instance_id, | ||
| %{ | ||
| "variable_id" => variable_id, | ||
| "instance" => %{"credential" => Map.from_struct(credential)} | ||
| } | ||
| ) do | ||
| {:ok, component_instance_attributes} | ||
| end | ||
| end | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| defmodule Uplink.Components.Instance.ModifyTest do | ||
| use ExUnit.Case | ||
| use Oban.Testing, repo: Uplink.Repo | ||
|
|
||
| alias Uplink.Components.Instance | ||
|
|
||
| import Mox | ||
|
|
||
| @cors_config """ | ||
| [ | ||
| { | ||
| "AllowedHeaders": ["*"], | ||
| "AllowedMethods": ["PUT"], | ||
| "AllowedOrigins": ["*"], | ||
| "ExposeHeaders": [] | ||
| } | ||
| ] | ||
| """ | ||
|
|
||
| @component_instance_attributes %{ | ||
| "id" => 1, | ||
| "current_state" => "active", | ||
| "credential" => %{ | ||
| "type" => "instance", | ||
| "username" => "someaccesskey", | ||
| "password" => "somesecretkey", | ||
| "host" => "s3.amazonaws.com", | ||
| "resource" => "us-east-1" | ||
| } | ||
| } | ||
|
|
||
| setup do | ||
| bypass = Bypass.open() | ||
|
|
||
| Application.put_env( | ||
| :uplink, | ||
| Uplink.Clients.Instellar, | ||
| endpoint: "http://localhost:#{bypass.port}/uplink" | ||
| ) | ||
|
|
||
| {:ok, bypass: bypass} | ||
| end | ||
|
|
||
| describe "s3 bucket" do | ||
| test "modify s3 bucket cors config", %{bypass: bypass} do | ||
| Uplink.Drivers.Bucket.AwsMock | ||
| |> expect(:modify, fn _params, options -> | ||
| assert [acl: _, cors: _] = options | ||
|
|
||
| {:ok, | ||
| %Formation.S3.Credential{ | ||
| secret_access_key: "somesecret", | ||
| bucket: "some-bucket-name", | ||
| access_key_id: "someaccesskey", | ||
| endpoint: "s3.us-east-1.s3endpoint.com", | ||
| region: "us-east-1", | ||
| cors: Jason.decode!(@cors_config) | ||
| }} | ||
| end) | ||
|
|
||
| Bypass.expect_once( | ||
| bypass, | ||
| "GET", | ||
| "/uplink/self/components/1", | ||
| fn conn -> | ||
| conn | ||
| |> Plug.Conn.put_resp_header("content-type", "application/json") | ||
| |> Plug.Conn.resp( | ||
| 200, | ||
| Jason.encode!(%{ | ||
| "data" => %{ | ||
| "attributes" => %{ | ||
| "generator" => %{"module" => "bucket/aws-s3"}, | ||
| "credential" => %{ | ||
| "type" => "component", | ||
| "username" => "someaccesskey", | ||
| "password" => "somesecretkey", | ||
| "host" => "s3.amazonaws.com", | ||
| "resource" => "us-east-1" | ||
| } | ||
| } | ||
| } | ||
| }) | ||
| ) | ||
| end | ||
| ) | ||
|
|
||
| Bypass.expect_once( | ||
| bypass, | ||
| "GET", | ||
| "/uplink/self/components/1/instances/1", | ||
| fn conn -> | ||
| conn | ||
| |> Plug.Conn.put_resp_header("content-type", "application/json") | ||
| |> Plug.Conn.resp( | ||
| 200, | ||
| Jason.encode!(%{ | ||
| "data" => %{ | ||
| "attributes" => @component_instance_attributes | ||
| } | ||
| }) | ||
| ) | ||
| end | ||
| ) | ||
|
|
||
| Bypass.expect_once( | ||
| bypass, | ||
| "PATCH", | ||
| "/uplink/self/components/1/instances/1", | ||
| fn conn -> | ||
| conn | ||
| |> Plug.Conn.put_resp_header("content-type", "application/json") | ||
| |> Plug.Conn.resp( | ||
| 200, | ||
| Jason.encode!(%{ | ||
| "data" => %{ | ||
| "attributes" => @component_instance_attributes | ||
| } | ||
| }) | ||
| ) | ||
| end | ||
| ) | ||
|
|
||
| assert {:ok, _result} = | ||
| perform_job(Instance.Modify, %{ | ||
| component_id: "1", | ||
| variable_id: "1", | ||
| component_instance_id: "1", | ||
| arguments: %{"acl" => "private", "cors" => @cors_config} | ||
| }) | ||
| end | ||
| end | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters