Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ES versions we test against #169

Merged
merged 2 commits into from
Sep 9, 2019

Conversation

jameslamb
Copy link
Collaborator

Working on #161 forced me to think about the versions we test against and the guarantees we make to our users. In this PR, I want to propose a new set of versions to test against and a documented strategy for choosing them.

I also created #168 to document some room for improvement beyond this PR.

@skirmer since you've been a user of uptasticsearch for so long, I'd love your feedback on the proposal here if you have time to take a look (focus on CONTRIBUTING.md). Thanks!

@skirmer
Copy link
Contributor

skirmer commented Sep 6, 2019

Looks alright to me, I think the additional support will be helpful.

@codecov-io
Copy link

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #169   +/-   ##
======================================
  Coverage    93.1%   93.1%           
======================================
  Files           8       8           
  Lines         595     595           
======================================
  Hits          554     554           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3283bca...bfbb6b9. Read the comment docs.

@jameslamb jameslamb merged commit 7ad2d22 into uptake:master Sep 9, 2019
@jameslamb jameslamb deleted the update_versions branch June 1, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants