Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] updated Elasticsearch versions in CI and docs #204

Merged
merged 3 commits into from
Jan 31, 2020

Conversation

jameslamb
Copy link
Collaborator

This PR updates the versions of Elasticsearch tested against in CI, per the agreement in CONTRIBUTING.md. It also removes some unnecessary intermediate versions in setup_local.sh.

Copy link
Collaborator

@austin3dickey austin3dickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you'll have to fix .ci/seed_es_on_travis.sh too!

@jameslamb
Copy link
Collaborator Author

Looks like you'll have to fix .ci/seed_es_on_travis.sh too!

oy yep, forgot that one! Maybe we'll do #168 one day

@codecov-io
Copy link

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files           8        8           
  Lines         597      597           
=======================================
  Hits          556      556           
  Misses         41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb9637...6f2770c. Read the comment docs.

@jameslamb
Copy link
Collaborator Author

oh cool it passed! I thought "oh no, 7.5.2 is gonna have some weird thing in it that we have to deal with". Very happy that it didn't!

Copy link
Collaborator

@austin3dickey austin3dickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@jameslamb jameslamb merged commit 5d110e7 into uptake:master Jan 31, 2020
@jameslamb jameslamb deleted the ci/es-versions branch June 1, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants