-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] updated Elasticsearch versions in CI and docs #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you'll have to fix .ci/seed_es_on_travis.sh
too!
oy yep, forgot that one! Maybe we'll do #168 one day |
Co-Authored-By: Austin Dickey <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 93.13% 93.13%
=======================================
Files 8 8
Lines 597 597
=======================================
Hits 556 556
Misses 41 41 Continue to review full report at Codecov.
|
oh cool it passed! I thought "oh no, 7.5.2 is gonna have some weird thing in it that we have to deal with". Very happy that it didn't! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE
This PR updates the versions of Elasticsearch tested against in CI, per the agreement in CONTRIBUTING.md. It also removes some unnecessary intermediate versions in
setup_local.sh
.