-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User natives #326
base: master
Are you sure you want to change the base?
User natives #326
Conversation
71eb664
to
d668b80
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
==========================================
- Coverage 89.78% 89.73% -0.05%
==========================================
Files 28 29 +1
Lines 3191 3205 +14
Branches 581 583 +2
==========================================
+ Hits 2865 2876 +11
- Misses 171 173 +2
- Partials 155 156 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
"skipFiles": [ | ||
"<node_internals>/**" | ||
], | ||
"type": "node-terminal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qué onda este cambio?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quizás debería dejarlo como estaba, no estoy seguro como estaba antes, pero me resultó mucho más cómodo para integrar con el debugger correr con node-terminal y agregar un run test:file
tsconfig.json
Outdated
@@ -12,16 +13,20 @@ | |||
"moduleResolution": "node", | |||
"resolveJsonModule": true, | |||
"esModuleInterop": true, | |||
"experimentalDecorators": true | |||
"experimentalDecorators": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no puedo creer que no tuviéramos este flag antes
Co-authored-by: Fernando Dodino <[email protected]>
Co-authored-by: Fernando Dodino <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Al tokeeeee 🚀 🌴 🗻 🌊
compareMaps(obj1, obj2) || | ||
compareSets(obj1, obj2) | ||
|
||
Assertion.addMethod('deepEquals', function (this: Chai.AssertionStatic, expected: any) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hace falta este helper? No se puede usar value.should.deep.eq(expected)
?
Otra cosa, esto estaría bueno que quede documentado en algún lado |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grosooo
@lgassman @ivojawer @fdodino ahí le terminé de dar una pasada al PR:
También hice que el comando Si querés confirmar que te anda todo en tu máquina mejor (tal vez funciona distinto en mac, linux, windows?). Y mergeamos! :) |
Permite construir un Intérprete que reciba funciones nativas escritas por el usuario
El principal cambio es que en lugar de importar las natives de WRE, se debe importar la función natives(), la cual se invoca conas las natives de usuario (o vacío si no hay) y devuelve un merge de éstas con las nativas del WRE.
Agrega un deepEquals en los assertions para verificar que el merge se produzca como corresponde