Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nueva nativa io.serve() #331

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Nueva nativa io.serve() #331

merged 1 commit into from
Jan 30, 2025

Conversation

PalumboN
Copy link
Contributor

@PalumboN PalumboN commented Jan 26, 2025 •
edited
Loading

@PalumboN PalumboN mentioned this pull request Jan 26, 2025
Open
4 tasks
@codecov Codecov
Copy link

codecov bot commented Jan 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.75%. Comparing base (feb04ff) to head (0f62a8c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/wre/lang.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   89.78%   89.75%   -0.03%     
==========================================
  Files          28       28              
  Lines        3190     3191       +1     
  Branches      581      581              
==========================================
  Hits         2864     2864              
- Misses        171      172       +1     
  Partials      155      155

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ivojawer
ivojawer approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@ivojawer ivojawer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dejo una duda pero por mi esta okkk 💎

src/wre/lang.ts
@@ -969,6 +969,11 @@ const lang: Natives = {

},

io: {
*serve(): Execution<RuntimeValue> {
return yield* this.reify(false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pregunta: esto es como quedaria la implementacion si no se corre en CLI no? O sea, si nadie mas settea la native.

Mi duda es si consideraste que en vez de retornar lance una excepcion 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo pensé, y preferí que no para que sea más fácil testear los juegos 👀

@PalumboN PalumboN merged commit d595ac1 into master Jan 30, 2025
2 of 4 checks passed
@PalumboN PalumboN deleted the new-io-native branch January 30, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivojawer ivojawer ivojawer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PalumboN @ivojawer