Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible referenced nodes #334

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Possible referenced nodes #334

wants to merge 7 commits into from

Conversation

ivojawer
Copy link
Contributor

@ivojawer ivojawer commented Feb 4, 2025

Agrega un helper para saber a que nodos podria estar referenciando un nodo reference

Usado por uqbar-project/wollok-lsp-ide#205

Otros cambios:

  • Fix printer de imports, ahora delega en el isGeneric que es lo correcto
  • En los calculadores de source maps cambie un poco la logica para que queden bien los character cuando se cambia el offset (solo lo arregle para los casos donde es un nodo de una sola linea)

@ivojawer ivojawer requested a review from PalumboN February 4, 2025 03:50
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.78%. Comparing base (d595ac1) to head (4d2eeb2).

Files with missing lines Patch % Lines
src/printer/print.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   89.78%   89.78%           
=======================================
  Files          28       28           
  Lines        3191     3201   +10     
  Branches      581      584    +3     
=======================================
+ Hits         2865     2874    +9     
- Misses        171      172    +1     
  Partials      155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivojawer ivojawer marked this pull request as ready for review February 4, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant