Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Travis variable for Codacy token in Travis automation script #53

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Use Travis variable for Codacy token in Travis automation script #53

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3ac17f9
use hidden variable for codacy token in travis script
SuperKogito Apr 17, 2021
a1163df
add {} to variable name
SuperKogito Apr 17, 2021
41454fe
use Github secrets to hide token
SuperKogito Apr 17, 2021
54e63fd
use one pair of {}
SuperKogito Apr 17, 2021
42001ae
try a different syntax with env section
SuperKogito Apr 17, 2021
3008b72
use ${var}
SuperKogito Apr 17, 2021
ec529ef
add env section with var definition
SuperKogito Apr 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ python:
- "3.6"
- "3.7"

env:
- CODACY_PROJECT_TOKEN=${CodacyToken}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I'm reading, I don't think this will work - you need to encrypt it https://docs.travis-ci.com/user/environment-variables/#encrypting-environment-variables

Copy link
Member Author

@SuperKogito SuperKogito Apr 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually following this
I don't see the need to encrypt. In this case the variable is defined under Settings and is hidden.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, if that works, then that works!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now it is not, so I am trying to figure the syntax. The alternative you mention would require me to install travis-ci and before that gem and that's extra work I am trying to avoid.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just posted a question on it; maybe someone see what is missing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could spin up a container if you don't want to install things on your host. I think the encrypted way is the right way to do it (at least what I did when I used travis) but I also think you're right that it should work the "easy" way too. I stopped using travis years ago so I don't know anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will give it a shot tomorrow. Actually I found out that the previous Codacy token was useless since we were not using codacy for this project anymore. I am also moving away from Travis since I hit my limit number of runs there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<personal opinion> I think the project would be fine without it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, if I cannot fix this, I will drop it. We already have codecov.


cache:
- pip

Expand All @@ -33,5 +36,5 @@ after_success:
- codecov
- coveralls
- coverage xml
- export CODACY_PROJECT_TOKEN=d4795dc96ed74f7c8415a2e8c3c42467
- export CODACY_PROJECT_TOKEN=${CodacyToken}
- python-codacy-coverage -r coverage.xml