Return driver object only when valid

[mabraham]

Without this, a driver that failed the sanity check could be returned. This leads to attempting to use it when checking URLs, which led to avoidable failures.

Fixes #92

[SuperKogito]

Lgtm 👍

[vsoch]

@mabraham if this fixes the error for you, please bump the version in the changelog and up the version in version.py. I'd also prefer the design pattern of having the driver set back to None if the error is triggered instead of having driver and default_driver (two variables) which I find more confusing.

[SuperKogito]

I'd also prefer the design pattern of having the driver set back to None if the error is triggered instead of having driver and default_driver (two variables) which I find more confusing.

@vsoch Can you explain why? I personally don't have a preference but I find this implementation cleaner.

[vsoch]

@vsoch Can you explain why? I personally don't have a preference but I find this implementation cleaner.

It's simple - as a user developer reading the code I only need to track one instead of two variables.

[mabraham]

@mabraham if this fixes the error for you, please bump the version in the changelog and up the version in version.py. I'd also prefer the design pattern of having the driver set back to None if the error is triggered instead of having driver and default_driver (two variables) which I find more confusing.

All done!

[vsoch]

Thank you @mabraham!