-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ProcessedBsm #135
Draft
iyourshaw
wants to merge
26
commits into
develop
Choose a base branch
from
integrate-processed-bsm
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@iyourshaw Is this PR ready for review? |
No, the plan is to hold this one over for the next Q2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Q2 Release
Fully integrates the new ProcessedBsm data structure into the Conflict Monitor's data processing.
Removes all dependence on the
OdeBsmData
class and on the ODE raw BSM Kafka topics, and instead reads fromtopic.ProcessedBsm
. Updates all logic that formerly used raw BSMs to useProcessedBsm
s instead.Removes the Repartition topology which is no longer needed because the
topic.ProcessedBsm
stream is pre-partitioned. Changes the BSM key and partitioning to useRsuLogKey
to match what the Geojson Converter produces.Tests
This PR was tested by verifying that the unit tests pass, and by running the following integration test scripts involving BSMs and verifying that they still produce the expected events:
Script-BSMs.csv
- BSM path EventsBSM_Revisions.csv
- Aggregated BSM Message Count Progression EventsConnectionOfTravel-connected.csv
,ConnectionOfTravel-u-turn.csv
- Connection of Travel, Lane Direction of Travel, and Stop Line Passage EventsApproachAndStopAtLine.csv
- Stop Line Stop EventsNote: This PR depends on the Geojson Converter PR: Convert ProcessedBsm to Feature #85 and requires ODE v. 4.0.0 and Geojson Converter v 2.0.0 JARs be available from Github Maven.
Temporary setting in settings.xml. Revert this when updated jars are available in this repo: