Partition by intersection #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undefined region to ProcessedMap and ProcessedSpat keys
…ased on intersection id
…tionEventTopology
John-Wiens
reviewed
Nov 28, 2023
There was a problem hiding this comment.
The Conflict Monitor has been using -1 to indicate an unknown intersectionId and Region. Do we want to be using -1 instead of null?
John-Wiens
reviewed
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the partitioning scheme to use intersection ID (and region) instead of RSU ID.
Uses the
IntersectionIdKeyinterface defined in the Geojson Converter to perform partitioning for MAPs, SPATs, BSMs, and output events. See: Geoson Converter PR #37.The logic that produces intersection events (in
IntersectionEventTopologyand related analytics classes) is all updated to perform join operations based on intersection ID instead of RSU IP.The
regionis treated as optional. If it is present, it is used in joins, but if it is absent (value -1), or set to the 'test' value of 0, it is ignored in comparisons and joins.BSM partitioning is performed in several steps:
RepartitionTopologyingests keyless BSMs fromtopic.OdeBsmJsonand writes them totopic.CmBsmJsonRepartitionpartitioned by RSU IP address, because they have not been joined with an intersection at this point. The Vehicle ID is also included in the key here.BsmEventTopologyreads the RSU-partitioned BSMs fromtopic.CmBsmJsonRepartition, and categorizes them geographically using the spatial index of MAP bounding boxes to constructBSMEventpaths that are also grouped by vehicle ID and RSU IP address. TheBsmEventTopologythen outputs theBSMEvents totopic.CMBsmEvents, and also writes the raw BSMs that are within intersection bounding boxes to a new topic,topic.CmBsmIntersection. Both outputs are partitioned by Intersection ID.MessageIngestTopologyreads the Intersection ID-partitioned BSMs fromtopic.CmBsmIntersection, and stores them in a time-windowed, queryable state store. This state store now only includes BSMs that are within MAP bounding boxes.IntersectionEventTopologyreads in the Intersection ID-partionedBSMEventsand removes duplicates (which are duplicate BSM paths seen by multiple RSUs) before passing them along to join with MAPs and SPATs.The unit tests were updated, and integration testing was performed using a test script with UTDOT data running with 3 partitions on 3 brokers.