Added Confluent Connect parameters to kafka template #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Sonar run has the following message: "The version of Java (11.0.21) used to run this analysis is deprecated, and SonarCloud no longer supports it. Please upgrade to Java 17 or later. Try setting that property? |
iyourshaw
reviewed
Jan 26, 2024
| } | ||
|
|
||
| } catch (InterruptedException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
I'd recommend using logger.error() instead of printing to stdout so that logging can be configured in a consistent way.
There was a problem hiding this comment.
As of Jan 28, 2024. All scans will fail regardless of the flag. This will be corrected when we update the CM to the latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom Kafka Template Producer which includes the configurations needed to connect to confluent cloud. This additional configuration is only needed by things such as the CMKafkaStateChangeEvents and Configuration topics which interface with kafka topics outside of a streams topology.