-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ODE reference version in pom.xml to 2.0.0-SNAPSHOT #73
Updated ODE reference version in pom.xml to 2.0.0-SNAPSHOT #73
Conversation
For this to work you will need to recursively update all the submodule references in addition to the POM reference in the following projects: Also will need to update |
I believe these submodules references should be updated after the latest changes have made it into the master branch & prior to the release, so this is outside the scope of this PR. |
This PR will cause the develop branch to break if the submodule references are not valid. The develop branch needs to be functional to do development work. |
Understood. I will update the submodule reference for the geojson converter in this project once usdot-jpo-ode/jpo-ode#537 and usdot-jpo-ode/jpo-geojsonconverter#52 are merged. Marking this PR as a draft for now until that is the case. |
Sounds good! 👍 😄 |
Since we are no longer targeting the EDIT: This would have been correct if the git submodule commit reference got updated prior to the candidate_r1 branch being merged into master. The fact that this is not guaranteed means that we should have in fact updated the git submodule commit reference here for redundancy. |
Problem
The version of the ODE for the upcoming release has been updated in usdot-jpo-ode/jpo-ode#537.
Solution
The pom.xml has been updated to correctly reference the upcoming release version.