Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Flaky Unit Test in InetPacketFunctionalTest #563

Closed

Conversation

dmccoystephenson
Copy link
Collaborator

@dmccoystephenson dmccoystephenson commented Jan 23, 2025

PR Details

Description

  • The logger in InetPoint was constructed using the @slf4j annotation to prevent flaky errors in tests.
  • Checkstyle violations in the changed files (formatting, Javadocs) were addressed.
  • InetPacketFunctionalTest was updated to consistently use junit.jupiter.api.

Related Issue

Motivation and Context

This addresses a unit test that was failing in the provided dev container.

How Has This Been Tested?

Unit tests were verified to pass in the provided dev container.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    ODE Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants