-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding JPO-Deduplicator to jpo-utils #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we configure these topologies to start based off of the same/similar environmental variables that the kafka-setup pod uses?
if KAFKA_TOPIC_CREATE_ODE
then the raw ODE topologies are enabled.
if KAFKA_TOPIC_CREATE_GEOJSONCONVERTER
then the Processed topologies are enabled.
if KAFKA_TOPIC_CREATE_CONFLICTMONITOR
then the CM topologies are enabled.
It might make sense to use different environmental variables, but having someway to enable/disable based off of environmental variables seems necessary before it can be part of jpo-utils
I added a few new environment variables to the sample.env file. Each of these variables is by default tied to the corresponding KAFKA_TOPIC_CREATE variable. For example, the ENABLE_PROCESSED_MAP_DEDUPLICATION is set to the value of KAFKA_TOPIC_CREATE_GEOJSONCONVERTER by default. This means that if the user is using the geojson converter, the corresponding deduplication topics will also be activated. Alternatively, users may manually configure each of these variables in their .env file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments. I was able to build the deduplicator and verify that it starts up correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.