Adding missing ode topics #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyourshaw
reviewed
Jan 9, 2025
jikkou/kafka-topics-values.yaml
Outdated
Comment on lines
85
to
90
| - topic.OdeTimRxJson | ||
| - topic.OdeDNMsgJson | ||
| - topic.OdeBsmDuringEventPojo | ||
| - topic.OdeBsmRxPojo | ||
| - topic.OdeBsmTxPojo | ||
| - topic.OdeTimBroadcastPojo |
There was a problem hiding this comment.
ode-svcs application.yaml shows several of these as "disabled", are they needed?
disabled-topics:
- "topic.OdeBsmRxPojo"
- "topic.OdeBsmTxPojo"
- "topic.OdeBsmDuringEventPojo"
- "topic.OdeTimBroadcastPojo"
There was a problem hiding this comment.
I noticed that "topic.OdeTimRxJson" was being used so I was thinking of adding them all, but I could remove the disabled topics.
There was a problem hiding this comment.
No strong opinion, I just noticed that.
iyourshaw
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some missing ODE kafka topics