Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: lib and services #511

Merged
merged 5 commits into from
Sep 4, 2023
Merged

refactor: lib and services #511

merged 5 commits into from
Sep 4, 2023

Conversation

gaboesquivel
Copy link
Contributor

@gaboesquivel gaboesquivel commented Aug 24, 2023

Splitting helpers as follows

lib/ for utilities with no side effects ( pure functions )
services/. they interact with apis and storage.

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for contracts-ui ready!

Name Link
🔨 Latest commit 945204b
🔍 Latest deploy log https://app.netlify.com/sites/contracts-ui/deploys/64f5f726b5154e0008e34948
😎 Deploy Preview https://deploy-preview-511--contracts-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Aug 24, 2023

Passing run #217 ↗︎

0 61 0 0 Flakiness 0

Details:

fix: imports
Project: Contracts UI Commit: 945204be60
Status: Passed Duration: 03:04 💡
Started: Sep 4, 2023 3:30 PM Ended: Sep 4, 2023 3:33 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@gaboesquivel gaboesquivel marked this pull request as ready for review August 25, 2023 14:30
@gaboesquivel gaboesquivel merged commit f10dc0a into master Sep 4, 2023
11 checks passed
@gaboesquivel gaboesquivel deleted the refactor-helpers branch September 4, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants