fix: catch instantiate reversion #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for contracts-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
statictype
changed the title
Passing run #208 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
statictype
changed the title
peetzweg
previously approved these changes
Aug 29, 2023
peetzweg
reviewed
Aug 29, 2023
|
|
||
| export function checkInstantiateReversion(dryRunResult: ContractInstantiateResult | undefined) { | ||
| return dryRunResult?.result.isOk | ||
| ? dryRunResult.result.asOk.result.flags.toHuman().includes('Revert') |
There was a problem hiding this comment.
dryRunResult.result.asOk.result.flags has no field/flag hasReverted or so?
Not familiar pjs to deeply still and can't find anything in the docs. Not sure if this is somehow available. Just did fire and forget search before our meeting.
peetzweg
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspect the flags and disallow instantiation in case a reversion took place
closes #494