-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: address build failures in some contracts (#24) #35
fix: address build failures in some contracts (#24) #35
Conversation
I think in this case and better course of action would be to use workspace dependencies like here use-ink/ink#1814 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of the examples. Left a few comments. I would also use workspace settings in order to maintain all examples with the latest version of ink!
Alternatively, can please also update all contracts to point to the latest ink! minor version?
3942b7a
to
f47703a
Compare
Hi @SkymanOne , I would probably look into the issue #1265 myself and give it a try if I had the opportunity to focus full-time on these. |
9372292
to
ce476c3
Compare
In this case, no need to bother with the workspace. As long as all dependencies are up to date, we should be good to go |
Description =========== The build process for some contracts was failing due to issues in certain Cargo.toml files. Changes ======= - Commented out `crate-type` in `Cargo.toml` files. There's a conflict with this setting when using the updated version of the Ink contract compiler. - Added `no_main` attribute in `lib.rs`. This was missing in some contracts, and the updated version of the compiler is printing warning messages when it's missing. This commit addresses issue use-ink#24
ce476c3
to
a2f1901
Compare
The build process for some contracts was failing due to issues in certain
Cargo.toml
files;Aside from some dependencies paths that needed to be adjusted, there seems to be conflicts with the
crate-type
setting when using the updated version of the Ink contract compiler. Additionally, theno_main
attribute was missing in some contracts.Description
crate-type
inCargo.toml
files to resolve conflicts with the updated Ink contract compiler.no_main
attribute inlib.rs
to address missing attributes in some contracts and prevent warning messages.Impacts
This pull request addresses issue #24
.