Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrades, version bump, example structure, cargo-contract sync, CI fix #2379

Merged
merged 12 commits into from
Jan 24, 2025

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Jan 23, 2025

@cmichi cmichi requested a review from ascjones as a code owner January 23, 2025 20:02
@cmichi cmichi removed the request for review from ascjones January 23, 2025 20:13
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.16%. Comparing base (c2e0857) to head (f68274a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crates/e2e/src/contract_build.rs 0.00% 1 Missing ⚠️
crates/env/src/engine/off_chain/impls.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2379      +/-   ##
==========================================
+ Coverage   58.72%   65.16%   +6.43%     
==========================================
  Files         140      147       +7     
  Lines        5875    12151    +6276     
  Branches     2355        0    -2355     
==========================================
+ Hits         3450     7918    +4468     
- Misses       2425     4233    +1808     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmichi cmichi changed the title Dependency upgrades, version bump, example structure, cargo-contract sync Dependency upgrades, version bump, example structure, cargo-contract sync, CI fix Jan 24, 2025
Copy link

github-actions bot commented Jan 24, 2025

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with cargo-contract-contract and comparing them to ink! master:

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
call-builder-return-value 17.108 17.108 0 0
e2e-runtime-only-backend 7.023 7.023 0 0
lang-err/call-builder-delegate 7.716 7.716 0 0
lang-err/call-builder 12.812 12.812 0 0
lang-err/constructors-return-value 5.998 5.998 0 0
lang-err/contract-ref 12.974 12.974 0 0
lang-err/integration-flipper 5.444 5.444 0 0
mapping 17.133 17.133 0 0
mother 20.679 20.679 0 0
sr25519-verification 3.717 3.717 0 0
static-buffer 6.568 6.568 0 0
storage-types 20.01 20.01 0 0
call-runtime 6.953 6.953 0 0
combined-extension 6.857 6.857 0 0
conditional-compilation 4.811 4.811 0 0
contract-invocation 13.446 13.446 0 0
contract-invocation/contract1 5.796 5.796 0 0
contract-invocation/contract2 5.548 5.548 0 0
contract-invocation/virtual_contract 8.222 8.222 0 0
contract-invocation/virtual_contract_ver1 5.182 5.182 0 0
contract-invocation/virtual_contract_ver2 5.199 5.199 0 0
contract-storage 12.985 12.985 0 0
contract-terminate 4.981 4.981 0 0
contract-transfer 7.876 7.876 0 0
contract-xcm 45.629 45.629 0 0
cross-contract-calls 14.74 14.74 0 0
cross-contract-calls/other-contract 4.834 4.834 0 0
custom-allocator 6.987 6.987 0 0
custom-environment 5.98 5.98 0 0
dns 17.188 17.188 0 0
e2e-call-runtime 5.957 5.957 0 0
erc1155 27.753 27.753 0 0
erc20 17.379 17.379 0 0
erc721 20.877 20.877 0 0
events 12.759 12.759 0 0
flipper 4.882 4.882 0 0
incrementer 4.758 4.758 0 0
lazyvec 9.821 9.821 0 0
multi-contract-caller 20.076 20.076 0 0
multi-contract-caller/accumulator 4.497 4.497 0 0
multi-contract-caller/adder 7.333 7.333 0 0
multi-contract-caller/subber 7.337 7.337 0 0
multisig 37.953 37.953 0 0
own-code-hash 7.48 7.48 0 0
payment-channel 17.456 17.456 0 0
psp22-extension 13.067 13.067 0 0
rand-extension 8.538 8.538 0 0
runtime-call-contract 4.837 4.837 0 0
trait-dyn-cross-contract-calls 9.06 9.06 0 0
trait-dyn-cross-contract-calls/contracts/incrementer 4.954 4.954 0 0
trait-erc20 17.792 17.792 0 0
trait-incrementer 5.026 5.026 0 0
upgradeable-contracts/delegator 11.812 11.812 0 0
upgradeable-contracts/delegator/delegatee 7.996 7.996 0 0
upgradeable-contracts/delegator/delegatee2 8.002 8.002 0 0
upgradeable-contracts/set-code-hash-migration 5.083 5.083 0 0
upgradeable-contracts/set-code-hash-migration/migration 4.883 4.883 0 0
upgradeable-contracts/set-code-hash-migration/updated-incrementer 5.434 5.434 0 0
upgradeable-contracts/set-code-hash 5.083 5.083 0 0
upgradeable-contracts/set-code-hash/updated-incrementer 4.931 4.931 0 0
wildcard-selector 5.619 5.619 0 0

Link to the run | Last update: Fri Jan 24 16:02:14 CET 2025

@cmichi cmichi merged commit 03a8eee into master Jan 24, 2025
2 checks passed
@cmichi cmichi deleted the cmichi-restructure+upgrade-deps-jan-25 branch January 24, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant