Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add needs_import_keys configuration #1379

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

chrisjsewell
Copy link
Member

needs_import_keys = {"my_key": "path/to/needs.json"}

Allows for the use of:

.. needimport:: my_key

As discussed with @arwedus

```python
needs_import_keys = {"my_key": "path/to/needs.json"}
```

Allows for the use of:

```restructuredtext
.. needimport:: my_key
```

As discussed with @arwedus
@chrisjsewell chrisjsewell requested review from ubmarco and danwos January 6, 2025 21:50
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.98%. Comparing base (4e10030) to head (d4d0842).
Report is 95 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1379      +/-   ##
==========================================
+ Coverage   86.87%   87.98%   +1.10%     
==========================================
  Files          56       60       +4     
  Lines        6532     7132     +600     
==========================================
+ Hits         5675     6275     +600     
  Misses        857      857              
Flag Coverage Δ
pytests 87.98% <100.00%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks.

@chrisjsewell chrisjsewell merged commit 77514a2 into master Jan 7, 2025
19 checks passed
@chrisjsewell chrisjsewell deleted the needs_import_keys branch January 7, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants