fix: Remove internal use of punycode module #4092
Draft
+349
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get the system tests to print it out, run node --trace-deprecation ../../bruno-cli/bin/bru.js run --env Prod --output junit.xml --format junit Upgrade a few packages and make some application code changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should address #2229 by a combination of package upgrades and changes to the internals. This differs from the approach of the PR #3640 which I'd highly recommend merging in first over doing it this way given the possibility of regression issues and the like.
Contribution Checklist:
Publishing to New Package Managers
Please see here for more information.