Implement subgroup support #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly improve safety by making the zero value invalid.
smlx
force-pushed
the
subgroups
branch
2 times, most recently
from
8e7e48a
to
343e6fd
Compare
Add new methods to the Keycloak client to: * look up user group permissions with support for subgroups. * look up ancestor groups of a given group. In addition, refactor the keycloak client to support paging through results from the Keycloak API. In support of the headline change, also add a "cache map" type which implements an in-memory cache map with individual value lifetimes.
Refactor permission engine to use the new keycloak client functionality which adds support for subgroups, and refactor session logic to use the new permission engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements subgroup support as described in the Lagoon docs.
Closes: #467