Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update notifications with more information for build states #3821

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Updates the notification service to produce warning message if a build reaches the state of complete with warnings and indicates that the build completed with warnings and to check the logs for further information.

Additionally, if a build fails, the step at which it failed will be included in the notification now.

For the webhook type notifications, failures also include the buildStep at which it failed. Completed webhook notifications include a new field warning: true if the build has warnings.

Closing issues

closes #3819 (partially anyway)

@shreddedbacon shreddedbacon marked this pull request as ready for review October 10, 2024 10:55
@shreddedbacon shreddedbacon added this to the 2.22.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Completed with Warnings" to CLI and Notification output
1 participant