Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tag count to tree view #3970

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

RoccoSmit
Copy link
Contributor

As per issue #3947 (comment) the tag list does not show usage numbers in tree view. This PR aims to add usage numbers

Design decisions:
Parent nodes only has a number next to them if they are uniquely used, they do not contain the sum of their child nodes

Examples:
image

Notes from the above:

  • Parent1 has no direct reference so no usage number is displayed
  • Parent2 has a direct reference so a usage number is displayed
  • Parent3 child1 has no direct reference so no usage number is displayed
  • Parent2 child1 has a direct reference so a usage number is displayed

web/src/components/TagTree.tsx Outdated Show resolved Hide resolved
- Updated var names to closer match var passed in by TagSection component
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack changed the title Add tag count to tree view feat: add tag count to tree view Oct 2, 2024
@boojack boojack merged commit f0d43c9 into usememos:main Oct 2, 2024
2 checks passed
@RoccoSmit RoccoSmit deleted the tree-view-tag-count branch October 2, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants