Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor has-oscal-namespace to use @nspredicate filter #2114

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aj-stein-gsa
Copy link
Contributor

Committer Notes

Closes #2113.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated the OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the OSCAL-Pages and OSCAL_Reference repositories.

@aj-stein-gsa aj-stein-gsa marked this pull request as ready for review February 22, 2025 05:49
@aj-stein-gsa aj-stein-gsa requested a review from a team as a code owner February 22, 2025 05:49
@xee5ch xee5ch mentioned this pull request Feb 22, 2025
9 tasks
@aj-stein-gsa
Copy link
Contributor Author

@iMichaela this proposed change is changing extant syntax and removes the need of a custom function in the liboscal-java layer. It is low risk while improving developer experience and requiring less code with existing implementations. Have you had a chance to review it?

@aj-stein-gsa aj-stein-gsa force-pushed the 2113-refactor-fn-has-oscal-name branch from ca64dc8 to 512626d Compare March 6, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant