Modify SSL script to create custom CA and set SAN #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user can trust the CA and everything will work "as expected" in the browser without warnings
|
I should add, to get this to work fully in your local browser, you'll need to trust the CA certificate that is created (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Guillaume-sousa,
In my local development, in order to get things working without any warnings or errors in my browser, I had to change how the SSL certificates are created. I modified
docker_set_ssl.shto create a custom certificate authority, and also made it so the certificate is created with the SAN defined as$HOSTNAME(since modern versions of Chrome do not accept the CN to identify a server, and the DNS SAN must be defined.Not sure if you would want to include this in the upstream, but I thought I'd submit it so you could take a look.