Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle whitespace with HTML tags #183

Conversation

david-waltermire
Copy link
Collaborator

Committer Notes

Fixed issue caused by a newline within an HTML tag that caused the resulting markdown to erroneously also include the same newline.

This change normalizes spacing within non <pre> HTML text nodes to ensure that newlines do not end up in the Markdown.

Resolves usnistgov/liboscal-java#5.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@david-waltermire david-waltermire changed the base branch from main to develop July 3, 2023 15:53
…sulting markdown to erroneously also include the same newline. Resolves usnistgov/liboscal-java#5.
@david-waltermire david-waltermire force-pushed the issue-liboscal-java-5-handle-intertag-whitespace branch from 402af9f to ecf79aa Compare July 3, 2023 19:55
@david-waltermire david-waltermire merged commit cbeedb8 into usnistgov:develop Jul 3, 2023
2 checks passed
@david-waltermire david-waltermire deleted the issue-liboscal-java-5-handle-intertag-whitespace branch July 3, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid handling of markdown text with nested style when saving to XML
1 participant