Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for yaml nulls #185

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Jul 4, 2023

Committer Notes

Added support for YAML null values: ~ or null.

This issue was raised by usnistgov/oscal-cli#84.

Resolves #157.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@david-waltermire david-waltermire linked an issue Jul 4, 2023 that may be closed by this pull request
Copy link
Collaborator

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am testing locally and it looks good so far, I will approve and take responsibility for the lack of coverage since I am approving.

@david-waltermire david-waltermire merged commit 7f1dd21 into usnistgov:develop Jul 5, 2023
2 checks passed
@david-waltermire david-waltermire deleted the issue84-oscal-cli-yaml-nulls branch July 5, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly handle YAML nulls
2 participants