Feature : Add a new annotation to configure envoy upstream weight #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Marchaud <[email protected]>
|
@mmcgarr hello, any news on this issue ? :) |
|
Hi @SoulKyu thanks for the contribution! The change looks good, I'll test it out next week and try get this merged in as soon as we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The goal of this PR is to setup an annotation permitting to add a weight on upstream.
A weight of 0 means disable the endpoint.
This brings no breaking change as a weigh of 1 is by default
This feature has been in production in Numberly for two years, time for the PR 👍