Switch to using the per-thread default stream #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insertinterestingnamehere
force-pushed
the
ptds
branch
from
2c88d82
to
3cd6230
Compare
|
Okay, this works with development versions of cupy and numba (with numba/numba#6936). Once those patches are available in the binaries we can switch to using the per-thread default stream to resolve #37. |
|
Note: this does not work with current cupy binaries for some reason. It does work with the development version if I compile it myself. See cupy/cupy#5092 for what details I have. We'll see if the next round of release binaries are okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that numba/numba#6936 is landing soon, this switches us over to using the per-thread default stream in parla. I'll see if I can also get cupy to also support switching to using per-thread-default-stream mode after import since that'll let us get rid of the import order dependence.
The import order issue may cause some existing apps to error out. Further investigation of the implications is pending.