Add killswitch for sentry based on gamestate #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-testing
calebchalmers
approved these changes
Nov 6, 2024
ut-robomaster/src/subsystems/chassis/command_sentry_position.cpp
Outdated
Show resolved
Hide resolved
calebchalmers
requested changes
Nov 10, 2024
There was a problem hiding this comment.
Previously, we had a timer which would wait until the match starts to begin moving. Could you keep the timer but start it once the game officially starts? I.e. once the match starts, the Sentry will wait maybe 10 seconds before it starts moving, to avoid excess drift on the field.
calebchalmers
removed
the
needs-testing
github-actions
bot
added
the
needs-testing
calebchalmers
removed
the
needs-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.