-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random DH parameters #5
Comments
Hi Jonathan! Thanks for taking an interest in this work and helping us with the codebase. First of all, I'm afraid the randomization code isn't exactly up to date in the public repo, as it probably got buried in the final sprint to get the paper submitted. I will take a more detailed look at it ASAP as part of reviewing your pull requests. (1) and (2) This is a good catch, the first and second joint could indeed be parallel and have |
Hello Filip, thanks a lot for your quick reply and the information! I started another training yesterday without constraining the random robots as done in (1)+(2)+(4) -- I will come back when I have results. (3) is now more clear, thanks for that! |
Hello again,
I am continuing to work on #3 and while creating some tests, I had some question regarding the random DH parameter generation process mentioned in your paper. I'll paste a screenshot below that I'll refer to (taken from your latest preprint).
I understand that you don't want to cover all possible kinematics, I was just wondering whether you had a specific reason for these limitations which were, from my perspectives, the only ones that kind of limit the generality of the "random" robots.
Regarding nr. 4: I ran some tests and computed the average loss for a "pose goal" as introduced in #4 . I get a translation error of ~3cm when I run my experiments, but as soon as I get rid of this assumption and follow the pseudo-code in the paper, with my pre-trained network, the translation error increases to ~25cm on average.
Thanks for your help!
The text was updated successfully, but these errors were encountered: