Fix Android build #629
Merged
Fix Android build #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlovich
changed the title
The standard library predefines c_char exactly for this purpose to get rid of manual CChar type aliases. While the alias in theory looks fine it was making cargo-ndk unhappy for some reason whereas using the natural stdlib c_char type works perfectly.
AFAICT trying to build with OpenMP support just results in a bunch of linker errors about missing OpenMP symbols. Disable for now.
Android can target x86_64 systems too. Add support for all the triples cargo-ndk lists as possibilities.
It's a configurable feature that can be disabled if needed, but I got a bunch of linker errors about unavailable C++ symbols from the static c++.a for some reason.
vlovich
force-pushed
the
fix-android-build
branch
from
8fc37d3 to
093115e
Compare
MarcusDunn
approved these changes
Jan 29, 2025
|
I don't believe the build failures have anything to do with my change. Looks like some platforms have bitrotted? |
|
Yeah they have, they've been failing for a while now. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard library predefines c_char exactly for this purpose to get rid of manual CChar type aliases. While the alias in theory looks fine, it's actually not if building for x64 Android. Similar problems exist in the CMake setup around assuming Android only targets aarch64. There's also a problem where openmp is enabled by default but for me on Android this just results in a bunch of undefined OpenMP symbols. Finally, I had issues linking against the C++ stdlib statically so made a default feature that links to the dynamic C++ library. I have confirmed that a complex Android project builds and links under cargo-ndk for all the triples listed by the cargo-ndk project.