Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working build.rs for apple metal #96

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Working build.rs for apple metal #96

merged 2 commits into from
Feb 25, 2024

Conversation

SilasMarvin
Copy link
Collaborator

@SilasMarvin SilasMarvin commented Feb 22, 2024

This build seems to be working for me on mac with an m2 chip. I haven't tested on linux or anything else. The bench fails to compile, but the simple example works and and the tests with my local code depending on the crate are working. There are probably some changes that need to be made for linux. I'm not really sure as bindgen and compilation in general is outside the scope of what I normally work with.

Note this is still a work in progress and I need to clean a few things up. I wouldn't merge it yet

@MarcusDunn
Copy link
Contributor

MarcusDunn commented Feb 23, 2024

Thanks! Let me know when you think it's in a ready to merge state and I'll test it on Linux and my M1 mac. The benchmarks haven't been kept up to date - so them not compiling is fine.

@MarcusDunn
Copy link
Contributor

I'm going to merge in #8 and do some testing - if you want to do some further cleanup feel free, but if it works for me I'll merge it to main.

@MarcusDunn MarcusDunn merged commit 62ac6b5 into utilityai:8-metal-on-mac Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants