Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language local #29

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Language local #29

merged 3 commits into from
Jul 27, 2023

Conversation

mlhale7
Copy link
Contributor

@mlhale7 mlhale7 commented Jul 19, 2023

What does this Pull Request do?

This PR makes it so that the properties "language" and "language_local" have different property URIs. The dbo:language (http://dbpedia.org/ontology/language) was selected.

How should this be tested?

Review property URI in RDF inquisitor. If the URI is not appropriate say why or suggest another. Check that this URI is not used elsewhere in the M3.

Comments

I also looked at http://www.europeana.eu/schemas/edm/language but I wasn't sure the definition was a good fit ("The value for this element is added by the Data Ingestion Team as part of the ingestion process, based on the language of the data provider").

Interested parties

@markpbaggett

Copy link
Contributor

@markpbaggett markpbaggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@markpbaggett markpbaggett merged commit 5d4f243 into main Jul 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants