Change label for spatial_local also! #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaljns
approved these changes
Jul 2, 2024
|
I'm going to iterate this up to v40.5 so that production will recognize this as a new/changed profile. |
|
Sadly we have to go up by 1 apparently for production. I'll make a final change (apologies as I learn how to work with the system). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This also changes the label for our spatial_local property (in addition to spatial). Since we have geographic values without URIs, we have two properties for the same content (differentiated by their form - string or URI). I neglected to address this earlier. Throughout our M3 we are using the same label for the controlled and uncontrolled values (except for with the keyword and subject properties).
How should this be tested?
Did I leave anything else out? Do all the checks for formatting pass?