Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add snapshot release workflow #11

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

ShookLyngs
Copy link
Collaborator

Changes

  • Add a GitHub workflow to release packages' snapshot, which performs the following tasks:
    1. Releases snapshots for every commit to the main or develop branch
    2. Creates a comment on the commit if snapshots was released

Request review

@Flouse @Dawn-githup Can you help review the process of the workflow?

@ShookLyngs ShookLyngs requested a review from duanyytop March 6, 2024 11:03
@ShookLyngs ShookLyngs self-assigned this Mar 6, 2024
@duanyytop
Copy link
Collaborator

duanyytop commented Mar 6, 2024

Do we need releases so frequently?

JoyID should only use the BTC transfer function and display the BTC balance, and the CKB package only needs internal references and does not need to rely on npmjs package.

I suggest setting the develop as the default branch and only releasing when the pull requests are merged to the main branch.

@Flouse
Copy link
Contributor

Flouse commented Mar 6, 2024

Do we need releases so frequently?

Yes, frequent releases may not be necessary.

I suggest setting the develop as the default branch and only releasing when the pull requests are merged to the main branch.

Agree with that.

Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @ShookLyngs ,
we think it doesn't hurt to release frequently if there is a tag mechanism clearly visible at the top of NPM package version page.
e.g. https://www.npmjs.com/package/@ckb-lumos/lumos?activeTab=versions

And the snapshot versions are convenient for testing.

So, let's merge this PR and focus on the new features.

@Flouse Flouse merged commit c3cfc7e into main Mar 6, 2024
1 check passed
@Flouse Flouse deleted the chore/snapshot-release branch March 6, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants