feat(rgbpp-sdk/ckb): Add spv client cell and btc tx proof #22
Conversation
| rawTx.cellDeps.push(buildSpvClientCellDep(spvClient)); | ||
|
|
||
| const rgbppUnlock = buildRgbppUnlockWitness(btcTxBytes, proof, ckbRawTx); | ||
| rawTx.witnesses = rawTx.witnesses.map((_) => rgbppUnlock); |
There was a problem hiding this comment.
Optional: I think only one witness is required for the current lock_script_group.
see https://github.com/ckb-cell/rgbpp/blob/e282e58af91511290309b4fca45ff59f759efad4/contracts/rgbpp-lock/src/main.rs#L97-L106
There was a problem hiding this comment.
I don't think the RGBPP cells belong to the same ScriptGroup, because the RGBPP lock args must be different.
args: out_index | bitcoin_tx_id
There was a problem hiding this comment.
It is possible that RGB++ cells are locked by the same btc utxo.
In that case, lock script of RGB++ cells or BTCTimeLock cells may be same, we should put lock witness only on the first position of the script group.
packages/ckb/src/rgbpp/btc-time.ts
Outdated
| const witnesses: Hex[] = inputs.map((_) => '0x'); | ||
|
|
||
| for await (const cell of btcTimeCells) { | ||
| const { spvClient, proof } = await spvService.fetchSpvClientCellAndTxProof({ | ||
| btcTxId: btcTxIdFromBtcTimeLockArgs(cell.output.lock.args), | ||
| confirmBlocks: BTC_JUMP_CONFIRMATION_BLOCKS, | ||
| }); | ||
| cellDeps.push(buildSpvClientCellDep(spvClient)); | ||
|
|
||
| const btcTimeUnlock = buildBtcTimeUnlockWitness(proof); | ||
| witnesses.push(btcTimeUnlock); | ||
| } |
There was a problem hiding this comment.
Optional: Only a single witness is required for the unlocking operation within the same script group.
See https://github.com/ckb-cell/rgbpp/blob/e282e58af91511290309b4fca45ff59f759efad4/contracts/btc-time-lock/src/main.rs#L58-L67
There was a problem hiding this comment.
I don't think the BTC time cells belong to the same ScriptGroup, because the BTC time lock args are most likely different.
args: lock_script | after | bitcoin_tx_id
packages/ckb/src/spv/index.ts
Outdated
| confirmBlocks, | ||
| }: SpvClientCellTxProofReq): Promise<SpvClientCellTxProofResponse> => { | ||
| let payload = { | ||
| id: 1, |
There was a problem hiding this comment.
The id parameter must be unique for each request following the JSON-RPC specification. Recommended to use a package such as uuid to generate a random ID for each request.
duanyytop
force-pushed
the
spv-client-proof
branch
from
4d67ac8 to
97117c4
Compare
Main Changes
cellDepsof the RGBPP tx and BTC time cells unlock txReviews
@Flouse @ShookLyngs @ahonn